-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
I-ALiRT - Test decom for HIT CCSDS #757
I-ALiRT - Test decom for HIT CCSDS #757
Conversation
I think that the next step for this is to populate HIT test data into the I-ALiRT SC packet. That way I can use it for testing architecture. Please comment on this idea. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is an interesting case because we won't ever get these packets, these are only for the spacecraft.
You currently have all of your decoding logic in the tests, you should move the calculations into the actual code and then only call the functions within the test.
Can you switch over to using the packet_file_to_datasets()
helper function here as well?
This seems like it is a good idea, but could also be complicated because you're having to inject specific bytes into another specific bytes object. If it is easy, it is likely worth doing, but I wouldn't spend too much time on it either. More important in my opinion is writing a generic function that can grab the proper HIT values you need. def process_hit(xarray_dataset):
# do something with ds["HIT_EVENT_DATA_00"], ...
# This should be agnostic of whether you are passing in only the HIT CCSDS decoded dataset or the I-ALiRT decoded dataset. |
imap_processing/tests/ialirt/test_data/l0/hit_ialirt_sample_header.csv
Outdated
Show resolved
Hide resolved
imap_processing/tests/ialirt/test_data/l0/hit_ialirt_sample.csv
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me!
9b259db
into
IMAP-Science-Operations-Center:dev
Change Summary
Overview
Test decom for HIT CCSDS
New Files
imap_processing/ialirt/packet_definitions/ialirt_hit.xml
imap_processing/ialirt/l0/decom_ialirt.py
imap_processing/ialirt/packet_definitions/ialirt.xml
Testing
imap_processing/tests/ialirt/unit/test_decom_ialirt_hit.py
Test data:
hit_ialirt_sample.ccsds
hit_ialirt_sample.csv
hit_ialirt_sample_header.csv